[cfe-commits] [PATCH] Allow typedef with unnecessary "typename" when ms-extensions are enabled.

Will Wilson will at indefiant.com
Wed May 16 14:36:33 PDT 2012


On 15 May 2012 00:48, Richard Smith <richard at metafoo.co.uk> wrote:
> On Sat, May 12, 2012 at 7:18 AM, Will Wilson <will at indefiant.com> wrote:
>>
>> > This is still only producing a warning if 'typename' is followed by
>> > something which isn't a type name in MS mode. We should reject this:
>> >
>> > int n; int k = typename n;
>>
>> Thanks for the review. I've updated the patch to only issue the
>> warning if an annotated typename was parsed, otherwise it defaults to
>> the error case. I've also updated the MS test cases. See what you
>> think...
>
>
> Thanks, I've committed this as r156786. I tweaked it slightly to only return
> 'false' if we managed to produce a (type) annotation.

Thanks! I've also closed http://llvm.org/bugs/show_bug.cgi?id=12715 as fixed.

Cheers,
Will.



More information about the cfe-commits mailing list