[cfe-commits] r156942 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/flags.c

[Chad Rosier]

On May 16, 2012, at 2:18 PM, Eli Friedman wrote:

> On Wed, May 16, 2012 at 2:12 PM, Chad Rosier <mcrosier at apple.com> wrote:
>> 
>> On May 16, 2012, at 2:08 PM, Eli Friedman wrote:
>> 
>>> On Wed, May 16, 2012 at 1:40 PM, Chad Rosier <mcrosier at apple.com> wrote:
>>>> Author: mcrosier
>>>> Date: Wed May 16 15:40:09 2012
>>>> New Revision: 156942
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=156942&view=rev
>>>> Log:
>>>> [driver] Allow the driver to directly accept the -no-implicit-float option, so that the
>>>> generation of implicit floating point instructions can be disable for ARM.
>>>> rdar://11409142
>>>> 
>>>> Modified:
>>>>    cfe/trunk/include/clang/Driver/CC1Options.td
>>>>    cfe/trunk/include/clang/Driver/Options.td
>>>>    cfe/trunk/lib/Driver/Tools.cpp
>>>>    cfe/trunk/test/Driver/flags.c
>>>> 
>>>> Modified: cfe/trunk/include/clang/Driver/CC1Options.td
>>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=156942&r1=156941&r2=156942&view=diff
>>>> ==============================================================================
>>>> --- cfe/trunk/include/clang/Driver/CC1Options.td (original)
>>>> +++ cfe/trunk/include/clang/Driver/CC1Options.td Wed May 16 15:40:09 2012
>>>> @@ -146,8 +146,6 @@
>>>>   HelpText<"The string to embed in the Dwarf debug flags record.">;
>>>>  def fforbid_guard_variables : Flag<"-fforbid-guard-variables">,
>>>>   HelpText<"Emit an error if a C++ static local initializer would need a guard variable">;
>>>> -def no_implicit_float : Flag<"-no-implicit-float">,
>>>> -  HelpText<"Don't generate implicit floating point instructions (x86-only)">;
>>>>  def fdump_vtable_layouts : Flag<"-fdump-vtable-layouts">,
>>>>   HelpText<"Dump the layouts of all vtables that will be emitted in a translation unit">;
>>>>  def femit_coverage_notes : Flag<"-femit-coverage-notes">,
>>>> 
>>>> Modified: cfe/trunk/include/clang/Driver/Options.td
>>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=156942&r1=156941&r2=156942&view=diff
>>>> ==============================================================================
>>>> --- cfe/trunk/include/clang/Driver/Options.td (original)
>>>> +++ cfe/trunk/include/clang/Driver/Options.td Wed May 16 15:40:09 2012
>>>> @@ -800,6 +800,8 @@
>>>>  def msmall_data_threshold_EQ : Joined <"-msmall-data-threshold=">, Group<m_Group>;
>>>>  def msoft_float : Flag<"-msoft-float">, Group<m_Group>, Flags<[CC1Option]>,
>>>>   HelpText<"Use software floating point">;
>>>> +def no_implicit_float : Flag<"-no-implicit-float">, Flags<[CC1Option]>,
>>>> +  HelpText<"Don't generate implicit floating point instructions">;
>>> 
>>> Please name the driver option -mno-implicit-float.
>> 
>> Sure that makes sense.  To be more explicit, you would like the driver option to be -mno-implicit-float and the cc1 option to remain -no-implicit-float, right?
> 
> I don't really care what the -cc1 option is…

Fixed in r156950.

 Chad

> -Eli