[cfe-commits] r156843 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprObjC.cpp test/SemaObjC/boxing-illegal-types.m test/SemaObjCXX/boxing-illegal-types.mm

jahanian fjahanian at apple.com
Tue May 15 13:05:24 PDT 2012


Couple of comments.

Documentation need be updated to document what the type of the enum expression will be; is it the underlying type or
a promoted type? This will influence what method being selected.

Please provide a CodeGenObjC test case showing the selected method.

- fariborz

On May 15, 2012, at 12:17 PM, Argyrios Kyrtzidis wrote:

> Author: akirtzidis
> Date: Tue May 15 14:17:44 2012
> New Revision: 156843
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=156843&view=rev
> Log:
> Allow objc @() syntax for enum types.
> 
> Previously we would reject it as illegal using a value of
> enum type and on ObjC++ it was illegal to use an enumerator
> as well.
> 
> rdar://11454917
> 
> Added:
>    cfe/trunk/test/SemaObjCXX/boxing-illegal-types.mm
> Modified:
>    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>    cfe/trunk/lib/Sema/SemaExprObjC.cpp
>    cfe/trunk/test/SemaObjC/boxing-illegal-types.m




More information about the cfe-commits mailing list