[cfe-commits] [PATCH 3/4] [clang.py] Implement Cursor.canonical

Gregory Szorc gregory.szorc at gmail.com
Sun May 13 20:58:21 PDT 2012


Committed with that line removed.

Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
	M	bindings/python/clang/cindex.py
	M	bindings/python/tests/cindex/test_cursor.py
Committed r156753

On 5/13/12 1:09 AM, Manuel Klimek wrote:
> +    assert cursors[1].canonical == cursors[0]
>
> I don't think we should test that - the documentation
> for clang_getCanonicalCursor in
> http://clang.llvm.org/doxygen/group__CINDEX__CURSOR__XREF.html does not
> specify which of the declarations is canonical. Thus we don't want the
> test to break if this changes in the future.
>
> Cheers,
> /Manuel
>
> On Sun, May 13, 2012 at 7:20 AM, Gregory Szorc <gregory.szorc at gmail.com
> <mailto:gregory.szorc at gmail.com>> wrote:
>
>     ---
>       bindings/python/clang/cindex.py             |   19 +++++++++++++++++++
>       bindings/python/tests/cindex/test_cursor.py |   13 +++++++++++++
>       2 files changed, 32 insertions(+)
>
>     _______________________________________________
>     cfe-commits mailing list
>     cfe-commits at cs.uiuc.edu
>     <mailto:cfe-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>






More information about the cfe-commits mailing list