[cfe-commits] r156713 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprObjC.cpp test/SemaObjC/objc-literal-nsnumber.m test/SemaObjC/objc-literal-sig.m

[Fariborz Jahanian]

On May 12, 2012, at 10:31 AM, Jordan Rose wrote:

> This shouldn't be a problem; the validation comes after the debugger support's implicit generation of +stringWithUTF8String:. This will catch if we ever make a mistake with the implicit method.

OK.  Please add a test case for when prototype is missing and when -fdebugger-support is on. You can add it to the same test file.

-Thanks,  Fariborz

> 
> Jordy
> 
> 
> On May 12, 2012, at 13:24, Fariborz Jahanian wrote:
> 
>> Under debugger (option is -fdebugger-support), we should continue to generate a valid AST. Please take a look at
>> test CodeGenObjC/objc-literal-debugger-test.m for an example.
>> 
>> - Fariborz
>> 
>> On May 12, 2012, at 8:53 AM, Jordy Rose wrote:
>> 
>>> Author: jrose
>>> Date: Sat May 12 10:53:41 2012
>>> New Revision: 156713
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=156713&view=rev
>>> Log:
>>> Don't crash on boxed strings when +stringWithUTF8String: is missing.
>>> 
>>> Also, unify some diagnostics for boxed expressions that have the same form.
>>> 
>> 
>