[cfe-commits] [PATCH 4/4] [clang.py] TranslationUnit API improvements

[Gregory Szorc]

On Mon, May 7, 2012 at 11:17 PM, Anders Waldenborg <anders at 0x63.nu> wrote:
> On Mon, May 07, 2012 at 10:08:46PM -0700, Gregory Szorc wrote:
>> Everything is addressed.
>
> Looks mostly good to me. A few minor things:
>
> TranslationUnit.from_source documentation should mention
> index. Also possibly mention the -x argument in the paragraph
> about "C++ in test.c".

What are you referring to?

> I guess you meant to change default value
> TranslationUnit.codeComplete unsaved_files to None aswell?

Good catch! Fixed in r156722.

> It would be useful if the stringrepresentation of
> TranslationUnitSaveError contained which error code it has, so it
> is evident what error it is when a backtrace printed
> to screen.

Fixed in r156722.

> Did you consider to make the different types of
> TranslationUnitSaveError subclasses?

Yes, and it didn't feel very Pythonic. If I were writing Java, this is
probably how I would do it. But, Python is not Java. If there is more
data hung off save errors later, then we have a case for different
classes. Until then, I think simplicity should win.