[cfe-commits] r156642 - in /cfe/trunk: lib/CodeGen/TargetInfo.cpp test/CodeGen/mips-vector-return.c

[Hatanaka, Akira]

Sorry, I will remember to be more specific in the future.
________________________________________
From: John McCall [rjmccall at apple.com]
Sent: Friday, May 11, 2012 6:53 PM
To: Hatanaka, Akira
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] r156642 - in /cfe/trunk: lib/CodeGen/TargetInfo.cpp test/CodeGen/mips-vector-return.c

On May 11, 2012, at 2:01 PM, Akira Hatanaka wrote:
> Author: ahatanak
> Date: Fri May 11 16:01:17 2012
> New Revision: 156642
>
> URL: http://llvm.org/viewvc/llvm-project?rev=156642&view=rev
> Log:
> Fix handling of vector return types.
>
> A vector should be returned via the hidden pointer argument except if its size
> is equal to or smaller than 16-bytes and the target ABI is N32 or N64.

When writing a commit message, please be a bit more specific about the
intended scope of your change.  All I'm looking for something like this:
  Fix handling of vector return types on MIPS.

That tells me straight off that your change shouldn't affect any other targets,
which helps me to review your patch.  It also makes it easier to read and
search the revision history.

Thanks!

John.