[cfe-commits] [Windows] Use thiscall as the default calling convention for class methods

[Timur Iskhodzhanov]

Hi John,

Can you please review the attached patch?

In two words what it does is
it overrides the CC_Default calling convention with
context.getDefaultMethodCallConv()
for all the used method definitions and calls.

What I personally don't like is that the method declarations are
stored with CC_Default and we have to replace that with
context.getDefaultMethodCallConv() wherever we use it.
Unfortunately, we can't change the CC in the global declarations storage.
I'd prefer to put the declarations into the storage with the right CC
but not sure:
a) if we should do it
b) how to do it
c) it's possible at all

OTOH, it looks like there are only two places we need to alter the
calling convention: method call and method definition :)
So maybe I'm trying too hard to generalize...

Looking forward for your review and suggestions!

Thanks,
Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_12785.patch
Type: application/octet-stream
Size: 3698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120511/458e7585/attachment.obj>