[cfe-commits] Clang change to detect and warn about unused private members

[Daniel Jasper]

Ok, I now reuse Sema::RecordDeclSetTy.

As for putting a bit into FieldDecl as opposed to the UnusedPrivateField
SetVector: It seems like FieldDecl is carefully crafted for size. Just
adding another bit for this use case doesn't seem right.

Please find the new version attached.

On Wed, May 9, 2012 at 5:41 PM, Jordan Rose <jediknil at belkadan.com> wrote:

>
> On May 9, 2012, at 19:24, Daniel Jasper wrote:
>
> >> - IsRecordFullyDefined should probably use SmallPtrSetImpl, to avoid
> specifying a size in the function prototype. (Not that it /really/ matters,
> but...)
> >>
> > But all the methods in SmallPtrSetImpl are protected!?
>
> Oops, sorry. I didn't actually check the docs; I just assumed it was like
> SmallVector and SmallVectorImpl. I suppose a typedef, then, is the next
> best thing, to avoid having to specify the count in two different places.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120510/ebd1e4bb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clangpatch
Type: application/octet-stream
Size: 12796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120510/ebd1e4bb/attachment.obj>