[cfe-commits] r156311 - /cfe/trunk/lib/CodeGen/CGExpr.cpp
Nuno Lopes
nunoplopes at sapo.pt
Mon May 7 11:48:53 PDT 2012
> On May 7, 2012, at 10:57 AM, Nuno Lopes wrote:
>> Author: nlopes
>> Date: Mon May 7 12:57:00 2012
>> New Revision: 156311
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=156311&view=rev
>> Log:
>> remove code to add bound checks for simple array accesses, since
>> those are already covered by the check with the objectsize builtin
>> remove the comparison of objectsize with -1. since it's an unsigned
>> comparison, it will always succeed if objectsize returns -1, which
>> is enough to have the check removed
>
> I'm disturbed that this doesn't require updating any test cases.
> Please fix this so that, in the future, patches like will require
> updating a test case. :)
>
> John.
Sure, will do it in a minute.
I also found strange that no test broke with this change..
Nuno
More information about the cfe-commits
mailing list