[cfe-commits] [patch] Fix -Wlarge-by-value-copy option in the driver.

[Jean-Daniel Dupas]

Thanks all for the review.

commited as r156161 with Chandler suggestions applied.


Le 4 mai 2012 à 10:01, James Molloy a écrit :

> Hi Jean-Daniel,
> 
> As Chandler and Doug have both LGTM'd it, I'll just say "Apologies" because
> this was an omission in my patch.
> 
> ... although there was no testcase, so... ;)
> 
> Cheers,
> 
> James
> 
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Jean-Daniel Dupas
> Sent: 03 May 2012 22:22
> To: cfe-commits cfe
> Subject: [cfe-commits] [patch] Fix -Wlarge-by-value-copy option in the
> driver.
> 
> Hi,
> 
> Recent change in CC1Options and Options definition broke the
> '-Wlarge-by-value-copy' argument. When trying to using it, clang cc1 failed
> with the following message:
> 
> error: unknown argument: '-Wlarge-by-value-copy'
> 
> Is this attached patch OK ? 
> 
> Thanks
> 
> -- Jean-Daniel
> 
> 
> 
> 
> 

-- Jean-Daniel