[cfe-commits] r156087 - /cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[Chris Lattner]

On May 3, 2012, at 11:38 AM, Richard Smith wrote:

> Author: rsmith
> Date: Thu May  3 13:38:45 2012
> New Revision: 156087
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=156087&view=rev
> Log:
> Remove diagnostic groups and DefaultIgnore from notes.

Should the clang tblgen plugin enforce that this doesn't happen?

-Chris

> 
> Modified:
>    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
> 
> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=156087&r1=156086&r2=156087&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Thu May  3 13:38:45 2012
> @@ -5250,17 +5250,13 @@
>   "unannotated fall-through between switch labels">,
>   InGroup<ImplicitFallthrough>, DefaultIgnore;
> def note_insert_fallthrough_fixit : Note<
> -  "insert '[[clang::fallthrough]];' to silence this warning">,
> -  InGroup<ImplicitFallthrough>, DefaultIgnore;
> +  "insert '[[clang::fallthrough]];' to silence this warning">;
> def note_insert_break_fixit : Note<
> -  "insert 'break;' to avoid fall-through">,
> -  InGroup<ImplicitFallthrough>, DefaultIgnore;
> +  "insert 'break;' to avoid fall-through">;
> def err_fallthrough_attr_wrong_target : Error<
>   "clang::fallthrough attribute is only allowed on empty statements">,
>   InGroup<IgnoredAttributes>;
> -def note_fallthrough_insert_semi_fixit : Note<
> -  "did you forget ';'?">,
> -  InGroup<IgnoredAttributes>;
> +def note_fallthrough_insert_semi_fixit : Note<"did you forget ';'?">;
> def err_fallthrough_attr_outside_switch : Error<
>   "fallthrough annotation is outside switch statement">,
>   InGroup<IgnoredAttributes>;
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits