[cfe-commits] r156082 - in /cfe/trunk/include/clang: AST/RecursiveASTVisitor.h Analysis/Analyses/FormatString.h

Richard Smith richard-llvm at metafoo.co.uk
Thu May 3 10:56:49 PDT 2012


Author: rsmith
Date: Thu May  3 12:56:49 2012
New Revision: 156082

URL: http://llvm.org/viewvc/llvm-project?rev=156082&view=rev
Log:
Fix a couple of cases of (innocuous) unmarked fallthrough. At least one of these
was unintentional. Found by -Wimplicit-fallthrough, patch by Alexander Kornienko!

Modified:
    cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
    cfe/trunk/include/clang/Analysis/Analyses/FormatString.h

Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=156082&r1=156081&r2=156082&view=diff
==============================================================================
--- cfe/trunk/include/clang/AST/RecursiveASTVisitor.h (original)
+++ cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Thu May  3 12:56:49 2012
@@ -1400,6 +1400,7 @@
     case TSK_Undeclared:
     case TSK_ImplicitInstantiation:
       TRY_TO(TraverseDecl(SD));
+      break;
 
     // We don't need to do anything on an explicit instantiation
     // or explicit specialization because there will be an explicit

Modified: cfe/trunk/include/clang/Analysis/Analyses/FormatString.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/Analyses/FormatString.h?rev=156082&r1=156081&r2=156082&view=diff
==============================================================================
--- cfe/trunk/include/clang/Analysis/Analyses/FormatString.h (original)
+++ cfe/trunk/include/clang/Analysis/Analyses/FormatString.h Thu May  3 12:56:49 2012
@@ -175,6 +175,7 @@
     switch (kind) {
       case PrintErrno:
         assert(IsPrintf);
+        return false;
       case PercentArg:
         return false;
       default:





More information about the cfe-commits mailing list