[cfe-commits] [Microsoft C++ ABI] Add initial support for array cookies

[Timur Iskhodzhanov]

On Tue, May 1, 2012 at 9:31 AM, John McCall <rjmccall at apple.com> wrote:
> On Apr 23, 2012, at 7:14 AM, Timur Iskhodzhanov wrote:
>> It allows compiling "delete [] array;" code.
>> It works exactly as the VS-generated cookies, except for the most
>> simple case when the array is used for a type without a destructor
>> (see the related FIXME in the test).
>
> r155886.
Thanks a lot!

> I changed this to use size_t instead of assuming 32 bits. I assume
> Win64 uses a 64-bit cookie.  It'd be nice if you could verify this.
Sounds good, I'll verify.

> I also did a lot of other refactoring that shouldn't really be read as
> comments on your code.
>
> My implementation doesn't seem to have the problem you saw
> when allocating arrays without destructors, so I went ahead and
> added a test case for that.
Awesome!

> Your test case named some local values (%3) and some types;  try
> not to do that.
Sorry about that, looks like I've missed one instance of %X.
I've just found out about FileCheck variables in the middle of
creating the patch :)

> John.