[cfe-commits] r155916 - in /cfe/trunk: include/clang/Driver/ lib/Driver/ lib/Frontend/ lib/FrontendTool/ test/Sema/ tools/driver/

[James Molloy]

Hi Andy,

> Are you intentionally removing -fpack-struct from the top-level driver? If
not, can you provide a quick fix? We have tests failing now:
> 
> clang -fpack-struct=8 ...
> error: unknown argument: '-fpack-struct'

This was not intentional - -fpack-struct has differing semantics between the
driver and CC1 - CC1 treats it as a separated argument  "-fpack-struct X"
and the driver as a Boolean flag only with no argument. I canonicalised them
so the argument version is now "-fpack-struct=" for both CC1 and driver, but
seemingly didn't fix the forwarding code.

Fixed in r155981, and I've added a testcase.

Apologies,

James

-----Original Message-----
From: Andrew Trick [mailto:atrick at apple.com] 
Sent: 02 May 2012 04:05
To: James Molloy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] r155916 - in /cfe/trunk: include/clang/Driver/
lib/Driver/ lib/Frontend/ lib/FrontendTool/ test/Sema/ tools/driver/


On May 1, 2012, at 7:57 AM, James Molloy <james.molloy at arm.com> wrote:

> Author: jamesm
> Date: Tue May  1 09:57:16 2012
> New Revision: 155916
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=155916&view=rev
> Log:
> Unify Options.td and CC1Options.td, in a first step towards unifying the
serialization logic in Frontend and Driver.
> 
> Reviewed by Eric, Doug and Chandler, and here:
http://llvm.org/reviews/r/7/
> 
> 
> Removed:
>    cfe/trunk/lib/Driver/CC1Options.cpp
> Modified:
>    cfe/trunk/include/clang/Driver/CC1Options.h
>    cfe/trunk/include/clang/Driver/CC1Options.td
>    cfe/trunk/include/clang/Driver/CMakeLists.txt
>    cfe/trunk/include/clang/Driver/Makefile
>    cfe/trunk/include/clang/Driver/OptParser.td
>    cfe/trunk/include/clang/Driver/OptTable.h
>    cfe/trunk/include/clang/Driver/Option.h
>    cfe/trunk/include/clang/Driver/Options.td
>    cfe/trunk/lib/Driver/CMakeLists.txt
>    cfe/trunk/lib/Driver/Driver.cpp
>    cfe/trunk/lib/Driver/OptTable.cpp
>    cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>    cfe/trunk/lib/FrontendTool/ExecuteCompilerInvocation.cpp
>    cfe/trunk/test/Sema/fpack-struct.c
>    cfe/trunk/tools/driver/cc1_main.cpp
>    cfe/trunk/tools/driver/driver.cpp
> 
> Modified: cfe/trunk/include/clang/Driver/CC1Options.h
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Option
s.h?rev=155916&r1=155915&r2=155916&view=diff
>
============================================================================
==


Hi James,

Are you intentionally removing -fpack-struct from the top-level driver? If
not, can you provide a quick fix? We have tests failing now:

clang -fpack-struct=8 ...
error: unknown argument: '-fpack-struct'

-Andy