[cfe-commits] r155951 - in /cfe/trunk: include/clang/AST/RecursiveASTVisitor.h unittests/Tooling/RecursiveASTVisitorTest.cpp

[Andrew Trick]

On May 1, 2012, at 2:58 PM, Richard Smith <richard-llvm at metafoo.co.uk> wrote:

> Author: rsmith
> Date: Tue May  1 16:58:31 2012
> New Revision: 155951
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=155951&view=rev
> Log:
> Fix RecursiveASTVisitor's data recursion to call the Traverse* functions if they
> have been overridden in the derived class. Also, remove a non-functional
> implementation of an incorrect optimization for ParenExprs.
> 
> Modified:
>    cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>    cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp
> 
> Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=155951&r1=155950&r2=155951&view=diff
> ==============================================================================

Richard,

I had to revert this because the following test failure was blocking other tests. Let me know if you need more details in order to fix it.

-Andy

FAIL: Clang :: Index/index-many-call-ops.cpp (156 of 163)
******************** TEST 'Clang :: Index/index-many-call-ops.cpp' FAILED ********************
Script:
--
c-index-test -index-file /s/mirror/tools/clang/test/Index/index-many-call-ops.cpp | FileCheck /s/mirror/tools/clang/test/Index/index-many-call-ops.cpp
--
Exit Code: 1
Command Output (stderr):
--
/s/mirror/tools/clang/test/Index/index-many-call-ops.cpp:46:11: error: expected string not found in input
// CHECK: [indexDeclaration]: kind: function | name: bar
          ^
<stdin>:6:48: note: scanning from here
[indexDeclaration]: kind: function | name: foo | USR: c:@F at foo# | lang: C | cursor: FunctionDecl=foo:12:6 (Definition) | loc: 12:6 | semantic-container: [TU] | lexical-container: [TU] | isRedecl: 0 | isDef: 1 | isContainer: 1 | isImplicit: 0
                                               ^
<stdin>:7:110: note: possible intended match here
[indexEntityReference]: kind: struct | name: S | USR: c:@S at S | lang: C++ | cursor: TypeRef=struct S:7:8 | loc: 13:3 | <parent>:: kind: function | name: foo | USR: c:@F at foo# | lang: C | container: [foo:12:6] | refkind: direct
                                                                                                             ^