[cfe-commits] [PATCH] "-gline-tables-only" flag for Clang

[Alexey Samsonov]

On Sun, Apr 29, 2012 at 3:07 AM, Eric Christopher <echristo at apple.com>wrote:

>
> Sending the revised (modulo r155697) patch. Please take a look.
>
> Codereview: http://codereview.appspot.com/6112056/#ps9001
>
>
> I think about the only comment I've got is whether or not we should use
> comparison operators instead of == and != in these sorts of cases?
>
> -    Dbg->EmitGlobalVariable(E->getDecl(), Init);
> +    if (CGM.getCodeGenOpts().DebugInfo !=
> CodeGenOptions::DebugLineTablesOnly)
> +      Dbg->EmitGlobalVariable(E->getDecl(), Init);
>
> I'd prefer it personally. Your thoughts?
>

Yes, the comparison operators look better. Using them now.
See attachment and http://codereview.appspot.com/6112056/#ps11001

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120501/4eca775e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue6112056_11001.diff
Type: application/octet-stream
Size: 18774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120501/4eca775e/attachment.obj>