[cfe-commits] r155679 - /cfe/trunk/lib/Driver/ToolChains.cpp

Chad Rosier mcrosier at apple.com
Fri Apr 27 07:59:18 PDT 2012


Ah.. fixed in 155708.  Thanks, James.

 Chad

On Apr 27, 2012, at 12:33 AM, James Molloy wrote:

> Hi Chad,
> 
> I'm no Darwin expert but I think this change is wrong - the "driver driver"
> is the fat binary driver in Apple's gcc based toolchain (? It's in something
> non-llvm..) and this comment is saying that the -arch option acts like it.
> It's not a redundant "driver" token :)
> 
> Cheers,
> 
> James
> 
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Chad Rosier
> Sent: 27 April 2012 01:36
> To: cfe-commits at cs.uiuc.edu
> Subject: [cfe-commits] r155679 - /cfe/trunk/lib/Driver/ToolChains.cpp
> 
> Author: mcrosier
> Date: Thu Apr 26 19:35:50 2012
> New Revision: 155679
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=155679&view=rev
> Log:
> Typo.
> 
> Modified:
>    cfe/trunk/lib/Driver/ToolChains.cpp
> 
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=
> 155679&r1=155678&r2=155679&view=diff
> ============================================================================
> ==
> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
> +++ cfe/trunk/lib/Driver/ToolChains.cpp Thu Apr 26 19:35:50 2012
> @@ -886,7 +886,7 @@
>       DAL->AddJoinedArg(0, Opts.getOption(options::OPT_mtune_EQ), "core2");
> 
>   // Add the arch options based on the particular spelling of -arch, to
> match
> -  // how the driver driver works.
> +  // how the driver works.
>   if (BoundArch) {
>     StringRef Name = BoundArch;
>     const Option *MCpu = Opts.getOption(options::OPT_mcpu_EQ);
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> 
> 
> 




More information about the cfe-commits mailing list