[cfe-commits] [cfe-dev] [review request] Removing redundant implicit casts in the AST, take 2

[David Blaikie]

On Thu, Apr 26, 2012 at 5:14 AM, Nicola Gigante
<nicola.gigante at gmail.com> wrote:
>
> Il giorno 25/apr/2012, alle ore 03:36, David Blaikie ha scritto:
>
>> Bumping this because I think it's a neat thing to tidy up.
>>
>> I've attached a patch that's updated for r155507. The only really
>> weird thing was a chunk of code in RewriteModernObjC.cpp that seemed
>> like it was doing strictly the wrong thing for casts (& perhaps was
>> only working as a no-op since explicit casts never did anything) &
>> removing it fixed the break caused by this patch & didn't regress
>> anything else.
>>
>> - David
>
> Great! I stopped adapting the patch every new release because
> no one seemed to care.

Yep - figured I'd lend a hand.

> Do you think it is ready to commit?

I think it seems OK, but I don't think I'm the right person to sign off on this

> Anybody wants to comment?

Hopefully,
- David