[cfe-commits] [patch] include_next <float.h> on windows for _msc_ver too, not just for __mingw32__

David Blaikie dblaikie at gmail.com
Tue Apr 24 14:04:15 PDT 2012


On Tue, Apr 24, 2012 at 1:54 PM, Nico Weber <thakis at chromium.org> wrote:
> Hi,
>
> the attached patch expands the include_next for <float.h> on windows
> to happen for _msc_ver too.
>
> The test case for this is:
>
> #include <float.h>
>
> inline bool IsFinite(const double& number) {
>  return _finite(number) != 0;
> }
>
> But since that test depends on having MinGW's or MSVC's float.h, I
> didn't add it to the patch.

Could you just restrict the test to certain platforms? (I've not
looked at how fine-grained our ability to do that with lit is, but you
could do it with similar macros in the test file than those in the
header... but that's perhaps a little redundant)

- David

>
> Ok?
>
> Nico
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>




More information about the cfe-commits mailing list