[cfe-commits] Fix for RecursiveASTMatcher not traversing nested template instatiations

Chandler Carruth chandlerc at google.com
Tue Apr 24 13:39:10 PDT 2012


On Tue, Apr 24, 2012 at 1:32 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> RecursiveASTVisitor::TraverseClassInstantiations completely ignores
> templates for which we have instantiated the declaration but not the
> definition, so your patch does not introduce the problem I was concerned
> about. So: LGTM.
>
> Separately from that, we have the question of whether we should be
> visiting such declarations. I think we probably should.
>

Yes, we absolutely should.

I don't understand why, if this is fixed, the original patch would still be
required? I may be missing something though, i've not studied this in depth.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120424/e28af115/attachment.html>


More information about the cfe-commits mailing list