[cfe-commits] r154749 - in /cfe/trunk: lib/AST/Decl.cpp test/CodeGenCXX/visibility.cpp

[Rafael Espíndola]

> If it's not a regression, I think I'd rather not screw around with visibility
> computation until tomorrow.

Unfortunately it is a regression. Clang 3.0 produces

@data_rect = global %struct.RECT zeroinitializer, align 4

current trunk produces

@data_rect = hidden global %struct.RECT zeroinitializer, align 4

> Visibility right now is just a minefield of
> subtle expectations and inadequate testing.

I agree, I should probably have tried rewriting this some time ago :-(

>  For example, apparently
> libc++ didn't pass tests (at least on Darwin) with this patch in — the
> dylib stopped exporting some symbol.  That might be a bug in libc++'s
> annotations, or it might be a subtle error in your patch (something
> getting overridden that shouldn't), or it might be evidence of a
> deeper flaw in the visibility logic.

OK. I will find out what was the problem first of all.

> If you're interested in investigating this, I believe all you need to do
> is run ./testit in libc++.
>
> John.

Thanks,
Rafael