[cfe-commits] libc++ #include fixes

[Howard Hinnant]

On Apr 16, 2012, at 4:19 PM, Richard Smith wrote:

> Hi,
> 
> The attached patch fixes the build of libc++ (at least for me and one other person on IRC) by removing the (apparently unused) include of <cxxabi.h> from src/stdexcept.cpp.
> 
> I've also added a bunch of #includes to the atomics tests in cases where they were missing. libc++ provides the needed symbols through another include, but libstdc++ doesn't -- this allows the atomics test suite to be used to test that clang does the right thing when building libstdc++.
> 
> Does this seem reasonable?

I'm ok with the added includes to the tests.

But I need the #include <cxxabi.h> in src/stdexcept.cpp to detect (or not) _LIBCPPABI_VERSION.  This is to manage a symbol migration when compiling against libcxxabi (http://libcxxabi.llvm.org/).  Some symbols moved from libc++.dylib to libcc++abi.dylib.

If I am the only one who needs this migration, I'm ok with putting this #include under #if __APPLE__.

Thanks,
Howard