[cfe-commits] r154749 - in /cfe/trunk: lib/AST/Decl.cpp test/CodeGenCXX/visibility.cpp

[John McCall]

On Apr 16, 2012, at 11:49 AM, Rafael Espíndola wrote:
>> I understand the desire to fix bugs, but this is a very subtle change with
>> poorly-understood repercussions, and it was made two days before
>> branch.  Please revert this, and we can talk about your more principled
>> design for visibility calculation (which looks very good!) as a post-3.1
>> thing.
> 
> I reverted it in 154846. I left the refactoring patches in.

Thanks.

> If at all possible I would like to propose the visibility changes to
> 3.1. The particular case in PR12552 was extracted from a mozilla test
> that failed with clang.

This is really, really late.  That said, we definitely don't want to break mozilla.
Is there a less aggressive fix?

John.