[cfe-commits] r154749 - in /cfe/trunk: lib/AST/Decl.cpp test/CodeGenCXX/visibility.cpp

[John McCall]

On Apr 14, 2012, at 8:21 AM, Rafael Espindola wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=154749&view=rev
> Log:
> Consider visibility attributes last, so that they take precedence.
> I am working on a cleaner fix, but this gets the case in PR12552 passing.

I understand the desire to fix bugs, but this is a very subtle change with
poorly-understood repercussions, and it was made two days before
branch.  Please revert this, and we can talk about your more principled
design for visibility calculation (which looks very good!) as a post-3.1
thing.

John.