[cfe-commits] [Patch][Review] Fix for error message PR12500

Jonathan Sauer jonathan.sauer at gmx.de
Fri Apr 13 08:27:51 PDT 2012


Hello,

> [Your patch (in fact, both of them) seem to have lost a couple of blank lines in the last hunk for test/CXX/temp/temp.spec/temp.expl.spec/p2.cpp]

Do you mean the fact that there are no blank lines between "}" and "Index":

| +  void N0::X0<void*>::ft1(void *, long) { } // expected-error{{does not enclose namespace}}
|  }
| Index: test/SemaCXX/qual-id-test.cpp
| ===================================================================

That must have happened when I prepared the patch from "svn diff"'s output, as when I first
sent it on Monday, my source tree had other changes from reverting the buggy r154248, which
I cut out. Of course I shouldn't have created a patch based on such inconsistent sources
in the first place, but I failed to think of that back then -- just as yesterday, I forgot
to update to TOT before making the last changes to the patch.

I hope I didn't cause any additional work!


Jonathan





More information about the cfe-commits mailing list