[cfe-commits] r154499 - in /cfe/trunk: lib/Sema/SemaOverload.cpp test/CodeGenCXX/atomicinit.cpp

[Eric Christopher]

On Apr 11, 2012, at 9:08 AM, David Chisnall <csdavec at swan.ac.uk> wrote:

> On 11 Apr 2012, at 16:57, Douglas Gregor wrote:
> 
>> This should be using S.Context.hasSameUnqualifiedType rather than ==.
>> 
>> It should also happen as the *second* conversion, after a potential lvalue-to-rvalue conversion.
>> 
>> Also, this really shouldn't be immediately returning 'true'. Rather, it should just update SCS and FromType and flow through to the end.
> 
> Hopefully fixed...
> 
>> Finally, should this really be considered an identity conversion? For example, how should this behave?
>> 
>> 	void f(_Atomic(int) x); // #1
>> 	void f(int x); // #2
>> 
>> 	f(3); // ambiguous, or prefers #2?
> 
> I have no idea about this one.  I would hope no one would ever write code that looked like that.

I could see it by accident. That said I'd prefer ambiguous here.

-eric