[cfe-commits] r154334 - in /cfe/trunk: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/no-objc-default-synthesize-properties.m

[David Blaikie]

On Mon, Apr 9, 2012 at 11:58 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> Author: fjahanian
> Date: Mon Apr  9 13:58:55 2012
> New Revision: 154334
>
> URL: http://llvm.org/viewvc/llvm-project?rev=154334&view=rev
> Log:
> objective-c: remove -fobjc-default-synthesize-properties from the driver.
> cc1 option remains though to invoke default property synthesis.
> // rdar://11209719

Is it possible this caused a failure in
'Index/complete-synthesized.m'? it's sent most of the clang buildbots
red for a while now.

- David

>
> Modified:
>    cfe/trunk/include/clang/Driver/Options.td
>    cfe/trunk/lib/Driver/Tools.cpp
>    cfe/trunk/test/Driver/no-objc-default-synthesize-properties.m
>
> Modified: cfe/trunk/include/clang/Driver/Options.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=154334&r1=154333&r2=154334&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Driver/Options.td (original)
> +++ cfe/trunk/include/clang/Driver/Options.td Mon Apr  9 13:58:55 2012
> @@ -460,8 +460,6 @@
>  def fno_objc_arc_exceptions : Flag<"-fno-objc-arc-exceptions">, Group<f_Group>;
>  def fobjc_atdefs : Flag<"-fobjc-atdefs">, Group<clang_ignored_f_Group>;
>  def fobjc_call_cxx_cdtors : Flag<"-fobjc-call-cxx-cdtors">, Group<clang_ignored_f_Group>;
> -def fobjc_default_synthesize_properties :
> -  Flag<"-fobjc-default-synthesize-properties">, Group<f_Group>;
>  def fobjc_exceptions: Flag<"-fobjc-exceptions">, Group<f_Group>;
>
>  def fobjc_gc_only : Flag<"-fobjc-gc-only">, Group<f_Group>;
>
> Modified: cfe/trunk/lib/Driver/Tools.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=154334&r1=154333&r2=154334&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Driver/Tools.cpp (original)
> +++ cfe/trunk/lib/Driver/Tools.cpp Mon Apr  9 13:58:55 2012
> @@ -2394,8 +2394,7 @@
>
>   // -fobjc-default-synthesize-properties=1 is default. This only has an effect
>   // if the nonfragile objc abi is used.
> -  if (Args.hasArg(options::OPT_fobjc_default_synthesize_properties) ||
> -      getToolChain().IsObjCDefaultSynthPropertiesDefault()) {
> +  if (getToolChain().IsObjCDefaultSynthPropertiesDefault()) {
>     CmdArgs.push_back("-fobjc-default-synthesize-properties");
>   }
>
>
> Modified: cfe/trunk/test/Driver/no-objc-default-synthesize-properties.m
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/no-objc-default-synthesize-properties.m?rev=154334&r1=154333&r2=154334&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/no-objc-default-synthesize-properties.m (original)
> +++ cfe/trunk/test/Driver/no-objc-default-synthesize-properties.m Mon Apr  9 13:58:55 2012
> @@ -1,4 +1,4 @@
> -// RUN: %clang  -fsyntax-only -fno-objc-default-synthesize-properties %s 2>&1 | FileCheck %s
> +// RUN: %clang  -fsyntax-only -fno-objc-default-synthesize-properties -fobjc-default-synthesize-properties %s 2>&1 | FileCheck %s
>
>  @interface I
>  @property int P;
> @@ -7,3 +7,4 @@
>  @implementation I
>  @end
>  // CHECK: warning: argument unused during compilation: '-fno-objc-default-synthesize-properties'
> +// CHECK: warning: argument unused during compilation: '-fobjc-default-synthesize-properties'
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits