[cfe-commits] r154195 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/mips-as.c

[Evgeniy Stepanov]

... which is totally fine.

On Mon, Apr 9, 2012 at 2:04 PM, Evgeniy Stepanov
<eugeni.stepanov at gmail.com> wrote:
> +// CHECK-MIPS32-EB-AS: as{{(.exe)?}}" "-march" "mips32" "-EB"
>
> You've got uneven number of quotes in this line.
>
> On Fri, Apr 6, 2012 at 11:15 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
>> Author: atanasyan
>> Date: Fri Apr  6 14:15:24 2012
>> New Revision: 154195
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=154195&view=rev
>> Log:
>> MIPS: Pass -EB/-EL argument to the assembler according to selected endian when compile for MIPS targets.
>>
>> Added:
>>    cfe/trunk/test/Driver/mips-as.c
>> Modified:
>>    cfe/trunk/lib/Driver/Tools.cpp
>>
>> Modified: cfe/trunk/lib/Driver/Tools.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=154195&r1=154194&r2=154195&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>> +++ cfe/trunk/lib/Driver/Tools.cpp Fri Apr  6 14:15:24 2012
>> @@ -5032,6 +5032,12 @@
>>       CmdArgs.push_back("-march");
>>       CmdArgs.push_back(CPUName);
>>     }
>> +
>> +    if (getToolChain().getArch() == llvm::Triple::mips ||
>> +        getToolChain().getArch() == llvm::Triple::mips64)
>> +      CmdArgs.push_back("-EB");
>> +    else
>> +      CmdArgs.push_back("-EL");
>>   }
>>
>>   Args.AddAllArgValues(CmdArgs, options::OPT_Wa_COMMA,
>>
>> Added: cfe/trunk/test/Driver/mips-as.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/mips-as.c?rev=154195&view=auto
>> ==============================================================================
>> --- cfe/trunk/test/Driver/mips-as.c (added)
>> +++ cfe/trunk/test/Driver/mips-as.c Fri Apr  6 14:15:24 2012
>> @@ -0,0 +1,21 @@
>> +// Check passing options to the assembler for MIPS targets.
>> +//
>> +// RUN: %clang -target mips-linux-gnu -### \
>> +// RUN:   -no-integrated-as -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=MIPS32-EB-AS %s
>> +// CHECK-MIPS32-EB-AS: as{{(.exe)?}}" "-march" "mips32" "-EB"
>> +//
>> +// RUN: %clang -target mipsel-linux-gnu -### \
>> +// RUN:   -no-integrated-as -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=MIPS32-EL-AS %s
>> +// CHECK-MIPS32-EL-AS: as{{(.exe)?}}" "-march" "mips32" "-EL"
>> +//
>> +// RUN: %clang -target mips64-linux-gnu -### \
>> +// RUN:   -no-integrated-as -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=MIPS64-EB-AS %s
>> +// CHECK-MIPS64-EB-AS: as{{(.exe)?}}" "-march" "mips64" "-EB"
>> +//
>> +// RUN: %clang -target mips64el-linux-gnu -### \
>> +// RUN:   -no-integrated-as -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=MIPS64-EL-AS %s
>> +// CHECK-MIPS64-EL-AS: as{{(.exe)?}}" "-march" "mips64" "-EL"
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits