[cfe-commits] [PATCH] pretty display of unprintable source and correct caret/range/fixup alignment

Argyrios Kyrtzidis kyrtzidis at apple.com
Thu Apr 5 10:55:26 PDT 2012


Hi Seth,

Thanks for your work, I'll take a look as soon as I can.

-Argyrios

On Apr 4, 2012, at 5:58 PM, Seth Cantrell wrote:

> I'm resending these because I just want to make sure they're not lost. Are changes okay for me to commit?
> 
> 
> On Apr 2, 2012, at 4:07 PM, Seth Cantrell wrote:
> 
>> Here are a couple of fixes on top of this patch.
>> 
>> On Sun, Apr 1, 2012 at 12:08 AM, Seth Cantrell <seth.cantrell at gmail.com> wrote:
>>> The first patch is to add support for reversed colors to llvm raw_ostreams.
>>> 
>>> The second patch uses the reversed colors to improve display of unprintable source, such as source code that includes invalid encodings, control characters, or unknown characters. Unprintable characters are displayed as <U+NNNN> and bytes that aren't valid encodings are displayed as <XX>, both using reversed colors. In addition diagnostic carets, highlighted ranges, and fixups are displayed with the appropriate adjustments. Adjustments are also made for characters that are printable but not ascii.
>>> 
>> <0001-zero-fill-Unicode-character-escapes-in-diagnostics.patch><0003-handle-expanding-empty-lines.patch>
> 
> 
> 
> On Apr 1, 2012, at 12:08 AM, Seth Cantrell wrote:
> 
>> The first patch is to add support for reversed colors to llvm raw_ostreams.
>> 
>> The second patch uses the reversed colors to improve display of unprintable source, such as source code that includes invalid encodings, control characters, or unknown characters. Unprintable characters are displayed as <U+NNNN> and bytes that aren't valid encodings are displayed as <XX>, both using reversed colors. In addition diagnostic carets, highlighted ranges, and fixups are displayed with the appropriate adjustments. Adjustments are also made for characters that are printable but not ascii.
>> 
>> <0001-Add-reverseColor-to-raw_ostream.patch><0001-Nicer-display-of-unprintable-source-and-fix-caret-di.patch>
> 
> 
> <0001-Add-reverseColor-to-raw_ostream.patch><0001-Nicer-display-of-unprintable-source-and-fix-caret-di.patch><0001-zero-fill-Unicode-character-escapes-in-diagnostics.patch><0003-handle-expanding-empty-lines.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list