[cfe-commits] [PATCH] C++ 11 statement attributes + switch labels fall-through detection

[Alexander Kornienko]

Ok, I'm not very good at editing diff files, but hope, that this should be
a valid patch. BTW, svn diff -x --ignore-eol-style doesn't seem to help

On Wed, Apr 4, 2012 at 4:36 PM, Jordan Rose <jediknil at belkadan.com> wrote:

> Sorry, but similarly, can you filter out the whitespace-only changes?
> They're all good, I presume, but they might as well be in a separate patch.
>
> svn diff -x --ignore-eol-style
> git diff --ignore-space-at-eol
>
> Jordy
>
>
>
> On Apr 4, 2012, at 19:18, Alexander Kornienko wrote:
>
> > Hi Chandler,
> >
> > You are right, it's better to separate apples from oranges. Here's a
> patch for statement attributes implementation. I'll post the rest after
> dealing with this one.
> >
> > On Wed, Apr 4, 2012 at 3:46 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
> > I've not looked at the patch yet, but to make reviewing easier:
> >
> >
> > On Wed, Apr 4, 2012 at 11:01 PM, Alexander Kornienko <alexfh at google.com>
> wrote:
> > I've also implemented one specific statement attribute as an example
> >
> > Can you please split the generic statement attribute work and the new
> attribute into two patches? These should be reviewed independently. One is
> a step toward support of a standard feature, the other is a brand new
> language extension. These have very different code review paths.
> >
> >
> >
> > --
> > Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151
> 221 77 957
> > Google Germany GmbH | Dienerstr. 12 | 80331 München
> >
> > AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg
> > Geschäftsführer: Graham Law, Katherine Stephens
> >
> > Tax ID:- 48/725/00206
> > VAT ID:- DE813741370
> >
> > <stmt-attributes3.diff>_______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>


-- 
Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München

AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

Tax ID:- 48/725/00206
VAT ID:- DE813741370
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120404/9e5e1ffd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stmt-attributes4.diff
Type: application/octet-stream
Size: 43112 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120404/9e5e1ffd/attachment.obj>