[cfe-commits] [Patch] Type-qualifiers on condtitional expression

Eli Friedman eli.friedman at gmail.com
Mon Apr 2 08:13:11 PDT 2012


On Mon, Apr 2, 2012 at 4:46 AM, Tim Northover <Tim.Northover at arm.com> wrote:
> Hi,
>
> When doing something like this:
>
> const int *CI;
> int *I;
> *(test ? I : CI) = 0
>
> clang currently doesn't put the combined qualifiers on the output type, which
> means that the assignment is allowed. I believe this patch implements correct
> C99 semantics (and sane behaviour for non-CVR type qualifiers).
>
> Could someone review it please?

It would be nice to have tests for both "x ? incomplete : complete"
and "z ? complete : incomplete" for the tests involving composite
types.

Otherwise, patch looks good.

-Eli



More information about the cfe-commits mailing list