[cfe-commits] r153568 - /cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp

[Jordan Rose]

I thought we had a PR tracking this for the analyzer or for Sema, but I can't find it. I definitely remember discussion about adding this feature, which stopped around the problem of "what makes two expressions suspiciously equivalent", but just because it's a difficult problem doesn't mean we shouldn't be working towards this warning.


On Mar 27, 2012, at 22:24, Ted Kremenek wrote:

> Author: kremenek
> Date: Wed Mar 28 00:24:50 2012
> New Revision: 153568
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=153568&view=rev
> Log:
> Fix suspicious comparison reported by PVS-Studio!
> 
> Modified:
>    cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp
> 
> Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp?rev=153568&r1=153567&r2=153568&view=diff
> ==============================================================================
> --- cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp (original)
> +++ cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Wed Mar 28 00:24:50 2012
> @@ -925,7 +925,7 @@
>            SM.getExpansionColumnNumber(ContaineeRBeg)) &&
>           (ContainerEndLine != ContaineeEndLine ||
>            SM.getExpansionColumnNumber(ContainerREnd) >=
> -           SM.getExpansionColumnNumber(ContainerREnd)));
> +           SM.getExpansionColumnNumber(ContaineeREnd)));
> }
> 
> void EdgeBuilder::rawAddEdge(PathDiagnosticLocation NewLoc) {
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits