[cfe-commits] [patch] command line options for MIPS float ABI configuration

[Hatanaka, Akira]

r153348

________________________________________
From: simon at atanasyan.com [simon at atanasyan.com] on behalf of Simon Atanasyan [satanasyan at mips.com]
Sent: Thursday, March 22, 2012 10:42 PM
To: Hatanaka, Akira; cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits][patch] command line options for MIPS float ABI configuration

On Wed, Mar 21, 2012 at 9:53 AM, Simon Atanasyan <satanasyan at mips.com> wrote:
> On Wed, Mar 21, 2012 at 5:52 AM, Hatanaka, Akira <ahatanaka at mips.com> wrote:
>> The patch looks fine. Two minor issues:
>>
>> 1. Curly braces aren't necessary if there is just one statement:
>
> Fixed.
>
>> 2.   "+soft-float" can be found in the manually written loop. Is it necessary to call std::find?
>
> Fixed.
>
> Updated patch is attached.

Ping.

--
Simon