[cfe-commits] Override ReadArrayCookie in MicrosoftCXXABI and explicitly mark it unimplemented (issue 5882057)

timurrrr at google.com timurrrr at google.com
Fri Mar 23 05:14:26 PDT 2012


Reviewers: rjmccall_apple.com,

Message:
Hi John,

Can you please review this small patch?
See http://llvm.org/bugs/show_bug.cgi?id=12333 for the details

Thanks,
Timur



Please review this at http://codereview.appspot.com/5882057/

Affected files:
   M     lib/CodeGen/MicrosoftCXXABI.cpp


Index: lib/CodeGen/MicrosoftCXXABI.cpp
===================================================================
--- lib/CodeGen/MicrosoftCXXABI.cpp	(revision 153329)
+++ lib/CodeGen/MicrosoftCXXABI.cpp	(working copy)
@@ -78,6 +78,12 @@
    //     delete[] p;
    //   }
    // Whereas it prints "104" and "104" if you give A a destructor.
+  void ReadArrayCookie(CodeGenFunction &CGF, llvm::Value *Ptr,
+                       const CXXDeleteExpr *expr,
+                       QualType ElementType, llvm::Value *&NumElements,
+                       llvm::Value *&AllocPtr, CharUnits &CookieSize) {
+    llvm_unreachable("Don't know how to handle array cookies yet!");
+  }
  };

  }





More information about the cfe-commits mailing list