[cfe-commits] Patch: Add R600 TargetInfo

[Eli Friedman]

On Thu, Mar 15, 2012 at 11:49 AM, Tom Stellard <thomas.stellard at amd.com> wrote:
> On Tue, Mar 13, 2012 at 03:07:02PM -0400, Tom Stellard wrote:
>> On Thu, Mar 08, 2012 at 01:19:31PM -0500, Tom Stellard wrote:
>> > Hi,
>> >
>> > This patch adds a TargetInfo definition for the R600 target,
>> > which represents AMD GPUs (HD2XXX-HD6XXX).  This patch depends
>> > on the r600 target triple patch, which was sent to llvm-commits:
>> > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120305/138626.html
>> >
>> > This is the bare minimum needed to successfully compile OpenCL kernels
>> > for the r600 target, and in the future we would like to add some target
>> > specific builtins for handling OpenCL C functions.
>> >
>> > Please Review.
>> >
>> > Thanks,
>> > Tom Stellard
>>
>> Has anyone had a chance to look at this patch yet?
>>
>> I have attached a second patch to this email that I would like to get
>> committed along with the first one.  The second patch adds some builtin
>> definitions for r600.
>>
>> -Tom
>>
>
> Hi,
>
> I've quashed the previous two patches together and made some additional
> changes, so here is an updated patch that adds a TargetInfo
> definition for the r600 target.  This patch replaces the previous two.
>
> Please Review.

+//
+// Authors: Tom Stellard <thomas.stellard at amd.com>

We don't generally put the names of developers into the source code.
See http://llvm.org/docs/DeveloperPolicy.html .


+class AMDGPUTargetInfo : public TargetInfo {

This class is pointless, since it only serves as a base class for one
other class.

Otherwise, looks fine.

-Eli