[cfe-commits] r152749 - /cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

Matt Beaumont-Gay matthewbg at google.com
Wed Mar 14 18:03:55 PDT 2012


OK, no problem.

On Wed, Mar 14, 2012 at 17:59, Anna Zaks <ganna at apple.com> wrote:
> We prefer to keep it there. It's all the code that needs to be updated in the near future and was commented out for different reasons.
>
> Thanks,
> Anna.
> On Mar 14, 2012, at 4:12 PM, Matt Beaumont-Gay wrote:
>
>> Author: matthewbg
>> Date: Wed Mar 14 18:12:42 2012
>> New Revision: 152749
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=152749&view=rev
>> Log:
>> '#if 0' out a variable that's only used in other preprocessor-disabled code.
>>
>> (Why are we keeping all of this code around anyway? Say the word and I'll
>> start swinging the delete hammer.)
>>
>> Modified:
>>    cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
>>
>> Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp?rev=152749&r1=152748&r2=152749&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp (original)
>> +++ cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Wed Mar 14 18:12:42 2012
>> @@ -64,8 +64,10 @@
>>                                        ExplodedNode *Pred,
>>                                        ExplodedNodeSet &destNodes) {
>>
>> +#if 0
>>   const CXXConstructorDecl *CD = E->getConstructor();
>>   assert(CD);
>> +#endif
>>
>> #if 0
>>   if (!(CD->doesThisDeclarationHaveABody() && AMgr.shouldInlineCall()))
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>




More information about the cfe-commits mailing list