[cfe-commits] [PATCH] minor cleanup in attribute-related diagnostics

Douglas Gregor dgregor at apple.com
Wed Mar 14 10:01:00 PDT 2012

On Mar 14, 2012, at 8:01 AM, Alexander Kornienko wrote:

> Hello!
> I'm only starting to work on clang and here's my first minor patch. Not much value, just cleaned a mess in a couple of diagnostic messages.
>  * synchronized %select{} blocks in warn_attribute_wrong_decl_type and err_attribute_wrong_decl_type diagnostics messages with enum AttributeDeclKind;
>  * replaced numeric constants with enum values in related code;
>  * removed unused messages (for example, ones forgotten during attribute cleanup in r124087).
> Please, review this patch.

Looks great, committed as r152725. Thanks!

	- Doug

More information about the cfe-commits mailing list