[cfe-commits] [PATCH] [msvc] Honor %INCLUDE%. It should know essential search paths with vcvarsall.bat.

NAKAMURA Takumi geek4civic at gmail.com
Mon Mar 12 17:08:09 PDT 2012

Thanks, Michael. Committed in r152589.

2012/3/13 Michael Spencer <bigcheesegs at gmail.com>:
> The patch looks fine, the only thing I worry about is this code not
> being accessible from a MinGW built Clang. I'd rather we restructure
> the surrounding code to be enabled if we are both hosted on Windows,
> and targeting Win32.

I thought, last night, it would be useless that clang should behave
like cl.exe on mingw, even with "clang -target win32".

I suppose mingw users may specify individual include paths via command
line. The case "clang -target win32" can be considered as "cross

But I rethink it might be useful as far as an user knows he is working
with ms headers.
For now, I leave _MSC_VER. In near future, I will reconfirm
"clang.exe" can behave similar among
{i686|x86_64}-{mingw32|mingw-w64|msvc}. Then I could prune _MSC_VER.

The conditioned block should be compiled also on mingw, that should make sense.


More information about the cfe-commits mailing list