[cfe-commits] Use GCC_INSTALL_PREFIX to initialize SysRoot

[Rafael Espíndola]

On the clang patch:

Typo: Retunrs in

 /// Retunrs the sysroot path after removing the trailing /.


+ #include "clang/Config/config.h"

This should be with the other includes

getSysRoot is returning a StringRef to a deleted object, no? Probably
the best is to avoid using SmallString in Compilation::getSysRoot
(which unfortunately means not using
llvm::sys::path::remove_filename).

The getSysRoot code is duplicated inline in Driver::BuildCompilation, no?

On the llvm patch:

GCC_INSTALL_PREFIX and DEFAULT_SYSROOT can go in the clang CMakeFile,
no? (thanks for adding GCC_INSTALL_PREFIX!).

Cheers,
Rafael