[cfe-commits] [PATCH 1/4] [clang.py] Refactor get_tu and get_cursor test helper functions into util.py
Manuel Klimek
klimek at google.com
Fri Mar 9 02:08:47 PST 2012
Hi Gregory,
yay for the simplification!
One minor thing: in test_cursor.py I'd probably get rid of the
intermediate vars for source...
Overall looks good.
Cheers,
/Manuel
On Mon, Mar 5, 2012 at 1:57 AM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> I don't believe anything functional changed with this patch. Just some
> housekeeping. It was big enough that I didn't think it was trivial and
> qualified for automatic commit.
>
> ---
> bindings/python/tests/cindex/test_cursor.py | 32 ++++------
> bindings/python/tests/cindex/test_diagnostics.py | 33 +++-------
> bindings/python/tests/cindex/test_location.py | 78 ++++++++++++----------
> bindings/python/tests/cindex/test_type.py | 32 +--------
> bindings/python/tests/cindex/util.py | 65 ++++++++++++++++++
> 5 files changed, 130 insertions(+), 110 deletions(-)
> create mode 100644 bindings/python/tests/cindex/util.py
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
More information about the cfe-commits
mailing list