[cfe-commits] [PATCH] Mangler does not mangle extern "C"'d symbols in ::std correctly

John McCall rjmccall at apple.com
Wed Mar 7 21:53:04 PST 2012


On Mar 7, 2012, at 9:41 PM, John McCall wrote:
> On Mar 2, 2012, at 7:08 AM, James Molloy wrote:
>> The attached patch fixes a bug in which a name in namespace ::std which is
>> within an extern "C" {} block* would not be mangled correctly. The patch
>> itself is simple, and comes from the lack of a call to
>> IgnoreLinkageSpecDecls().
>> 
>> As part of general code smell I have also moved two other places where
>> IgnoreLinkageSpecDecls()'s functionality was being duplicated to using that
>> function.
>> 
>> Regression test attached. Is it OK to commit?
> 
> Looks good.

I see that my mail client is just woefully mangling the threading and this is long-ago reviewed.  Carry on.

John.



More information about the cfe-commits mailing list