[cfe-commits] [PATCH RFC] Stop defining __GNUC__ for MSVC builds

[Douglas Gregor]

On Mar 2, 2012, at 4:16 PM, Aaron Ballman wrote:

> There are a lot of references on the web which relate __GNUC__ to GCC
> for compiler discovery
> (<http://sourceforge.net/apps/mediawiki/predef/index.php?title=Compilers#GCC_C.2FC.2B.2B>,
> <http://www.ocf.berkeley.edu/~pad/tigcc/doc/html/cpp_SEC15_GNUC.html>,
> etc).  This translates into a fair number of cross-compiler projects
> with code like this:
> 
> #if defined(__GNUC__)
>  // Do GCC things
> #elif defined(_MSC_VER)
>  // Do MSVC things
> ...
> #endif
> 
> This currently leads to problems when compiling with Clang because
> __GNUC__ (and friends) are always defined, even when compiling for MS
> compatibility (PR 11790).  I've attached a patch which addresses this
> by only defining __GNUC__ et al when MSVC mode is not set.  This means
> code like the above will work as expected.
> 
> Thoughts?

-  // Currently claim to be compatible with GCC 4.2.1-5621.
-  Builder.defineMacro("__GNUC_MINOR__", "2");
-  Builder.defineMacro("__GNUC_PATCHLEVEL__", "1");
-  Builder.defineMacro("__GNUC__", "4");
-  Builder.defineMacro("__GXX_ABI_VERSION", "1002");
+  if (!LangOpts.MSCVersion) {

This should probably just check LangOpts.MicrosoftMode.

I'm not sure about the general approach, though. Even when compiling in Microsoft-compatible mode, Clang is still much more GCC-like than MSVC-like. I would venture a guess that

	// Do GCC things

is far more likely to be standards-conforming code that Clang will accept than

	// Do MSVC things

especially when dealing with template libraries in C++.

	- Doug