[cfe-commits] r151862 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/Sema/variadic-incomplete-arg-type.c

jahanian fjahanian at apple.com
Fri Mar 2 09:10:19 PST 2012


On Mar 1, 2012, at 4:21 PM, Eli Friedman wrote:

> On Thu, Mar 1, 2012 at 3:42 PM, Fariborz Jahanian <fjahanian at apple.com> wrote:
>> 
>> +  // c++ rules are enfroced elsewhere.
> 
> Spelling.
> 
>> +  if (!getLangOptions().CPlusPlus &&
>> +      !E->getType()->isVoidType() &&
> 
> I really don't think we want to allow "void a(int x, ...); void b() {
> a(1, (void)0); }".
> 
>> +      RequireCompleteType(E->getExprLoc(), E->getType(),
>> +                          diag::err_incomplete_type))
> 
> diag::err_call_incomplete_argument is a bit more specific.

In r151923.

- Thanks, Fariborz

> 
> -Eli




More information about the cfe-commits mailing list