[cfe-commits] Please review: add -fthread-sanitizer clang flag

[Chandler Carruth]

Sorry for missing this patch.

LGTM, please commit with one style nit:

--- lib/CodeGen/BackendUtil.cpp (revision 151830)
+++ lib/CodeGen/BackendUtil.cpp (working copy)
@@ -126,6 +126,11 @@
   PM.add(createAddressSanitizerPass());
 }

+static void addThreadSanitizerPass(const PassManagerBuilder &Builder,
+                                    PassManagerBase &PM) {
+  PM.add(createThreadSanitizerPass());
+}
+

The indent seems off on the PM parameter...

On Thu, Mar 1, 2012 at 12:05 PM, Kostya Serebryany <kcc at google.com> wrote:

> ping.
> (fresh patch which applies to r151830 attached).
>
>
> On Mon, Feb 13, 2012 at 3:24 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>> Please review the following clang patch that adds a
>> flag -fthread-sanitizer.
>> This flag enables ThreadSanitizer instrumentation committed to llvm as
>> r150423.
>> The patch includes one test for -fthread-sanitizer and one similar test
>> for -faddress-sanitizer.
>> This patch does not modify the linker flags (as we do it
>> for -faddress-sanitizer) because the run-time library is not yet
>> committed and it's structure in compiler-rt is not 100% clear.
>>
>> http://codereview.appspot.com/5663045/
>>
>> Thanks,
>>
>> --kcc
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120301/33a6e448/attachment.html>