[cfe-commits] r151058 - /cfe/trunk/lib/Headers/unwind.h

[Rafael Espíndola]

> Oh, you should mention that you're building with -fvisibility=hidden.
> You want clang's unwind.h to push "default" around the #include_next?
> That seems reasonable, but it also seems to indicate a bug in
> libunwind's header. Have you filed that? Do they agree that it's a
> bug, or is there a reason that they shouldn't override the user-chosen
> visibility in their header file?

I would guess it is a bug, as it looks like they intend the header to
be a drop in replacement for gcc's. But then again you have to define
_GNU_SOURCE, so I am not sure what the intentions are.

> The gcc manual does say, "Be aware that headers from outside your
> project, in particular system headers and headers from any other
> library you use, may not be expecting to be compiled with visibility
> other than the default. You may need to explicitly say `#pragma GCC
> visibility push(default)' before including any such headers.", so
> maybe it makes more sense for Firefox to specify the visibility it
> wants before #including unwind.h?

We do that for headers we know don't have them, but I would like to
avoid having to add code just to be able to use clang (or having to
remove libunwind-dev).

> Jeffrey

Cheers,
Rafael