[cfe-commits] FW: [PATCH] Fix tag decls/enum constants in function prototypes

[James Molloy]

No problems Chandler, I’ll fix those then commit. Thanks for the review!

From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: 27 February 2012 11:39
To: James Molloy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] FW: [PATCH] Fix tag decls/enum constants in function prototypes

On Mon, Feb 27, 2012 at 2:59 AM, James Molloy <James.Molloy at arm.com<mailto:James.Molloy at arm.com>> wrote:
Please? Anyone? Ping? :(

Sorry... I'm trying to emerge from my February rockpile... And it happens I can finish this one easily now that I have a moment...

The patch looks great semantically. A couple of nit-picks. Just commit once these are fixed. =]

1) Don't set all the properties on the new test files.

2) Use the more conventional capitalized initialism loop variable naming convention: I, E, DI, DE, etc.


Sorry for the mess of review, I shouldn't vanish for 4 weeks at a time...

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120227/a6613db3/attachment.html>