[cfe-commits] r151172 - in /cfe/trunk: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/new-array-init-exceptions.cpp

[Benjamin Kramer]

On 23.02.2012, at 23:29, Chad Rosier <mcrosier at apple.com> wrote:

>
> On Feb 23, 2012, at 2:27 PM, Benjamin Kramer wrote:
>
>>
>> On 23.02.2012, at 13:02, Sebastian Redl wrote:
>>
>>> On 22.02.2012 21:46, Chad Rosier wrote:
>>>> Hi Sebastian,
>>>> The test you added here is failing on one of our internal buildbots.
>>>>
>>>> Here's the exact errors:
>>>> ******************** TEST 'Clang :: CodeGenCXX/new-array-init-exceptions.cpp' FAILED ********************Script:
>>>> --
>>>> /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang-build/Release/bin/clang -cc1 -internal-isystem /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang-build/Release/bin/../lib/clang/3.1/include -std=c++11 -triple i386-unknown-unknown -fexceptions -fcxx-exceptions /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGenCXX/new-array-init-exceptions.cpp -emit-llvm -o - | FileCheck /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGenCXX/new-array-init-exceptions.cpp
>>>> --
>>>> Exit Code: 1
>>>> Command Output (stderr):
>>>> --
>>>> /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin10-R/clang.src/test/CodeGenCXX/new-array-init-exceptions.cpp:20:12: error: expected string not found in input
>>>> // CHECK: [[LPAD]]:
>>>>          ^
>>>> <stdin>:56:1: note: scanning from here
>>>> ; <label>:27 ; preds = %25
>>>> ^
>>>> <stdin>:56:1: note: with variable "LPAD" equal to "31"
>>>> ; <label>:27 ; preds = %25
>>>> ^
>>>> <stdin>:56:10: note: possible intended match here
>>>> ; <label>:27 ; preds = %25
>>>>
>>>>
>>> Huh, do labels look this differently in Release mode?
>>
>> clang doesn't emit names for instructions and BasicBlocks when NDEBUG is set.
>
> Of course Ben knows.. :)
>
> How do you disable this test for Release builds?

The easiest way is adding a "REQUIRES: asserts" line to the test.

- Ben
>
>> - Ben
>>
>>>
>>> Sebastian
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>