[cfe-commits] [PATCH] A lot of MS declspecs being turned on

Aaron Ballman aaron at aaronballman.com
Thu Feb 23 13:42:50 PST 2012


On Thu, Feb 23, 2012 at 3:38 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Wed, Feb 22, 2012 at 6:50 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Instead of doing single patches for all of these, I've put them into a
>> single patch.  In each case, all I've done is turn on the declspecs
>> and added test cases to ensure they behave as expected.  This patch
>> supports four more low-hanging fruit declspecs.
>
> I would prefer that you don't turn on -fms-compatibility for a bunch
> of random tests; please put the relevant tests in their own file.
>
> Otherwise, looks fine.

Fair enough -- I was debating that too, but went the "keep the related
tests together" route.  But not an issue.

Thanks!

~Aaron




More information about the cfe-commits mailing list