[cfe-commits] [Patch] Warn about non-standard format strings (PR12017)

[Ted Kremenek]

On Feb 20, 2012, at 11:25 AM, Hans Wennborg <hans at chromium.org> wrote:

> Keeping -Wformat-nonstandard out of -Wformat and having it in
> -pedantic sounds perfectly fine to me. I expect that lines up with
> what gcc does too.

Ok, I think that approach is worth experimenting with.

I've looked at the patch, and other than the default configuration of the warnings, it looks okay to me.

One nit on wording in the diagnostic: "non-standard" or "non-portable"?  The former is more technically accurate, but the latter is the implication the user cares about.  What do you think?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120220/362824bd/attachment.html>